Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/remove hot fix #19

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Issue/remove hot fix #19

merged 2 commits into from
Oct 26, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Oct 26, 2023

Pull Request

Description

Removes the hot fix introduced in #18. The multiple spatial coords are now dealt with inside ocf_datapipes

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #19 (f39dfcf) into main (a6c3019) will increase coverage by 0.24%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   92.99%   93.23%   +0.24%     
==========================================
  Files           2        2              
  Lines         214      207       -7     
==========================================
- Hits          199      193       -6     
+ Misses         15       14       -1     
Files Coverage Δ
pvnet_app/__init__.py 100.00% <100.00%> (ø)
pvnet_app/app.py 93.20% <ø> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfulu dfulu requested a review from peterdudfield October 26, 2023 13:39
@dfulu dfulu merged commit 80fb7b8 into main Oct 26, 2023
5 checks passed
@peterdudfield peterdudfield deleted the issue/remove_hot_fix branch February 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants